[11.x] Fix job not logged in failed_jobs table if timeout occurs within database transaction#54173
Merged
Merged
Conversation
decaylala
force-pushed
the
timeout-job
branch
from
January 13, 2025 11:57
3b01cee to
7766b96
Compare
decaylala
force-pushed
the
timeout-job
branch
from
January 13, 2025 12:34
7766b96 to
193b8a4
Compare
crynobone
reviewed
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #49389
When a job times out with an open database transaction on the same connection as the failed jobs table, rolling back the transaction ensures the failed job is logged correctly. Without this rollback, the transaction remains uncommitted. As a result, database updates are rolled back when the worker process is terminated, preventing the failed job from being saved.
Additionally, this PR ensures that any open database transactions are rolled back to the root level. This guarantees that nested transactions are also properly rolled back; otherwise, the failed job might not be logged in the database.