[11.x] Simplify Codebase by Using qualifyColumn Helper Method#54187
Merged
taylorotwell merged 1 commit intolaravel:11.xfrom Jan 14, 2025
Merged
Conversation
.x] Simplify Codebase by Using qualifyColumn` Helper MethodqualifyColumn Helper Method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify Codebase by Using
qualifyColumnHelper MethodThis PR simplifies the Laravel codebase by replacing repetitive string concatenations for qualifying column names with the
qualifyColumnhelper method. This change improves readability, reduces code duplication, and aligns with Laravel’s focus on clean and maintainable code.Key Changes:
$table . '.' . $column) with thequalifyColumnmethod in various parts of the Eloquent ORM.hasOne,hasMany,morphOne,morphMany, etc.) inHasRelationshipsto usequalifyColumn.Benefits: