[11.x] Fix deprecation warnings in optimize:clear and optimize - #54197
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
cosmastech
marked this pull request as ready for review
January 15, 2025 01:57
shaedrich
reviewed
Jan 15, 2025
| $this->components->info('Clearing cached bootstrap files.'); | ||
|
|
||
| $exceptions = Collection::wrap(explode(',', $this->option('except'))) | ||
| $exceptions = Collection::wrap(explode(',', $this->option('except') ?? '')) |
Contributor
There was a problem hiding this comment.
Is there the need, to call all these at all if $this->option('except') is null? Maybe let's just wrap that in an if statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #54190
Passing null to
explode()produces a deprecation warning. I coalesced the option to a blank string, and modified the tests so the tests will fail if there's a deprecation warning.