Add a report/log option to filesystem exceptions without throwing#54212
Merged
taylorotwell merged 6 commits intoJan 17, 2025
Merged
Conversation
…ration errors are logged if wanted/needed.
Member
|
The |
…n handler from app container instead.
Contributor
Author
|
That’s great! I hadn’t noticed that dependency issue before. I fixed it by using the exception handler from the application container only if it's available. If it’s not, the code simply does nothing. This solution also preserves the dependency injection strategy for the adapter. As for the code style, it’s not passing, but I read in the contribution docs that it’s not required at the code review stage since it’s automatically handled at the merge. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature that allows users to configure whether filesystem operation errors should be logged without throwing exceptions.
Key Changes:
reportconfiguration option to the disk configuration infilesystems.php."throw" => truein their disk configuration."report" => true.Use Case:
This feature provides flexibility for users who want to monitor filesystem errors through logs instead of disrupting their application flow with exceptions. It’s particularly useful for non-critical operations where logging errors is sufficient or for monitoring/auditing purposes.
Example Configuration:
Impact:
throwistrue, exceptions will still be thrown.throwisfalseandreportistrue, errors will be logged.This change maintains backward compatibility while providing more granular error-handling options for filesystem operations.