[11.x] Fix line-ending mismatch in CliDumperTest::testArray and CliDumperTest::testObject#54222
Merged
taylorotwell merged 1 commit intolaravel:11.xfrom Jan 17, 2025
AhmedAlaa4611:11.x
Merged
[11.x] Fix line-ending mismatch in CliDumperTest::testArray and CliDumperTest::testObject#54222taylorotwell merged 1 commit intolaravel:11.xfrom AhmedAlaa4611:11.x
taylorotwell merged 1 commit intolaravel:11.xfrom
AhmedAlaa4611:11.x
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a platform-specific issue in the
CliDumperTest::testArrayandCliDumperTest::testObjecttest, where differences in line endings (\r\n vs. \n) between operating systems (Windows vs. Unix-based systems) caused the test to fail.Problem
The test failed when running on systems with different line-ending.
Solution
Normalize line endings for both expected and actual output.