[11.x] apply our new Pint rule to the /tests directory#54325
Merged
Conversation
I originally omitted these files to keep the PR smaller, but adding back now for consistent styling throughout repo. these are purely indentation whitespace changes. the `bad-syntax-strategy.php` file is not valid PHP so we need to omit it, or it throws a Pint error.
Contributor
Author
|
since this is a large PR that mostly contains whitespace changes, you can toggle the hiding the whitespace in the diff viewer to confirm only the behavior changes. |
Contributor
|
I really like this push to include the styling rules into the repo, especially since it means we can use it ourselves when making pull requests or on our own projects. Maybe once we migrate these rules, we can add them to the base project laravel/laravel. I didn't realize we could toggle whitespace in the diff viewer, thanks for that haha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally omitted these files to keep the PR smaller, but adding back now for consistent styling throughout repo. these are purely indentation whitespace changes.
the
bad-syntax-strategy.phpfile is not valid PHP so we need to omit it, or it throws a Pint error.