[11.x] Fix casts + withAttributes - #54422
Merged
Merged
Conversation
tontonsb
marked this pull request as draft
January 30, 2025 17:44
tontonsb
marked this pull request as ready for review
January 31, 2025 22:17
tontonsb
changed the title
withAttributes
tontonsb
changed the title
withAttributeswithAttributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue was reported in a comment so I decided to test the pending attributes with multiple methods of casting attributes.
The error was becacuse of an inappropriate use of
hasAttribute, this fixes it and adds a test for that case and some more cast tests.