[11.x] Fix docblocks for code that calls enum_value()#54432
Merged
taylorotwell merged 3 commits intolaravel:11.xfrom Jan 31, 2025
Merged
[11.x] Fix docblocks for code that calls enum_value()#54432taylorotwell merged 3 commits intolaravel:11.xfrom
enum_value()#54432taylorotwell merged 3 commits intolaravel:11.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any place where we call
enum_value(), we can actually accept a backed or unit enum. Because\BackedEnumextends\UnitEnum, it's not necessary to union the two types. For instance:@template TEnum of \UnitEnum|\BackedEnumis redundant and can be reduced toTEnum of \UnitEnum.Also allows QueuedClosure and PendingChain to accept an enum for the connection. I can back this change out, as it is not strictly a docblock change.