Revert "[11.x] Use Str::wrap() instead of nesting Str::start() inside Str::finish()"#54528
Merged
Merged
Conversation
shaedrich
changed the title
rodrigopedra
reviewed
Feb 9, 2025
| { | ||
| return (new Collection($this->references)) | ||
| ->map(fn ($messageId) => Str::wrap($messageId, '<', '>')) | ||
| ->map(fn ($messageId) => Str::of($messageId)->start('<')->finish('>')) |
Contributor
There was a problem hiding this comment.
This is not reversing, this is adding a Stringable instance overhead on each $references element.
Previous code used nested calls to Str::start() and Str::finish()
Contributor
Author
There was a problem hiding this comment.
Well, it reverses the functionality which is now asserted by the added test, not necessarily the syntax, which is more readable imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53987 potentially changes the output of
Illuminate\Mail\Mailables\Headers::referencesString()As @tontonsb explained in #53987 (comment), previously, already wrapped strings would not be wrapped again, but now, they would, resulting in two leading and two trailing angle brackets.
This deviation wasn't discovered by a test, so I added one.