[11.x] use exec function if the symlink function is unavailable#54651
Merged
Conversation
If the `symlink` function is not available, it falls back to using the `exec` function to run the `ln -s` command, which creates a symbolic link using the shell.
aisuvro
changed the title
shaedrich
reviewed
Feb 17, 2025
Contributor
Author
|
Thank you for the merge. |
shaedrich
reviewed
Feb 17, 2025
| return symlink($target, $link); | ||
| if (function_exists('symlink')) { | ||
| return symlink($target, $link); | ||
| }else{ |
Contributor
There was a problem hiding this comment.
I guess, you are missing an additional space on both sides for the style check to pass:
Suggested change
| }else{ | |
| } else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
symlinkfunction is unavailable, it falls back to using theexecfunction to run theln -scommand, creating a symbolic link using the shell.I have tried both GitHub actions and cpanel. By default, the symlink() function does not exist for security reasons. We usually fix it by manually using the bash command "ln -s" to fix this issue.
GitHub action image below.
Cpanel image below.
