[11.x] make the Eloquent missing attribute handler more accurate by changing offsetExists#54654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have recently implemented the
Model::handleMissingAttributeViolationUsingcallback in staging and production environments to allow the request to continue without exceptions, but still be notified about strict mode failures. However, due to the way theoffsetExistsmethod is currently implemented, we are getting a lot of false positives on missing attributes when usingissetor??checks.This PR aims to resolve that by temporarily disabling the check while retrieving the attribute, and then restoring it to the previous setting.