[11.x] Rename Redis parse connection for cluster test method to follow naming conventions#54721
Merged
taylorotwell merged 1 commit intolaravel:11.xfrom Feb 20, 2025
jackbayliss:rename-test
Merged
[11.x] Rename Redis parse connection for cluster test method to follow naming conventions#54721taylorotwell merged 1 commit intolaravel:11.xfrom jackbayliss:rename-test
taylorotwell merged 1 commit intolaravel:11.xfrom
jackbayliss:rename-test
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply updates a test method to follow the consistency of the other methods in the same test class, found it on my travels.
Minor, I know, but keeps it consistent. This can be aimed at 12.x if it's easier.
Also, while I'm here is it worth PR'ing a pint rule to ignore snake case issues? As if I run pint it tries to convert all method names to snake case and my IDE is blowing up:
Could be useful as not sure if you prefer snake case or camel atm?