[11x.] Improved typehints for InteractsWithDatabase#54748
Merged
taylorotwell merged 3 commits intoFeb 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I'm using the DB helper functions, if it's been a while, I usually have to check if it accepts a table name, a model instance, or a class-string of the Model. I thought I may help others by making the docblocks more explicit.
Technically class-string is a subtype of string, but I think being a bit more explicit is helpful.
Furthermore, I have made the mistake more than once where I thought I could pass a list of associative arrays to see if they all exist. 😅