Ensure ValidationEmailRuleTest skips tests requiring the intl extension when unavailable#54918
Merged
taylorotwell merged 1 commit intolaravel:11.xfrom Mar 6, 2025
Merged
Conversation
Member
|
Can you send this to |
alikhosravidev
force-pushed
the
test/validation-rules
branch
from
512b2d2 to
bb31829
Compare
Contributor
Author
I've updated the PR to target the 11.x branch as requested. |
crynobone
approved these changes
Mar 6, 2025
crynobone
requested changes
Mar 6, 2025
| ); | ||
| } | ||
|
|
||
| #[RequiresPhpExtension('intl')] |
…ord` and `testCombiningRules` due to intl extension dependency.
alikhosravidev
force-pushed
the
test/validation-rules
branch
from
bb31829 to
8f4b54d
Compare
crynobone
approved these changes
Mar 6, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
#[RequiresPhpExtension('intl')]attribute to thetestValidateMxRecordandtestCombiningRulesmethods in theValidationEmailRuleTestclass.These methods rely on the intl PHP extension because the Email class
validateMxRecordmethod depends on it. The attribute ensures the tests are only executed if the required extension is available, preventing potential test failures in environments without the extension.