Skip to content

[10.x] Fix attribute name used on Validator instance within certain rule classes#54943

Merged
taylorotwell merged 1 commit into
10.xfrom
10/pr-54845
Mar 10, 2025
Merged

[10.x] Fix attribute name used on Validator instance within certain rule classes#54943
taylorotwell merged 1 commit into
10.xfrom
10/pr-54845

Conversation

@crynobone

Copy link
Copy Markdown
Member

Backport PR #54845 to Laravel 10

… rule classes

Backport PR #54845 to Laravel 10

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review March 8, 2025 14:18
@taylorotwell taylorotwell merged commit a4f7a8f into 10.x Mar 10, 2025
@taylorotwell taylorotwell deleted the 10/pr-54845 branch March 10, 2025 17:30
@jorgecasar

Copy link
Copy Markdown

This PR cause error in our application. I guess, this kind of changes should be a patch. Out request validator start receive __dot__ instead of . and broke all our requests.

I leave the comment just to helps others in the same situation.

And it also helps if you update the Changelog, because it was fixed to 10.48.28 and there are no info about 10.48.29.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants