[12.x] Fix DataPart API misuse in email embed methods - second parameter is filename, not cid #57606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinheli
force-pushed
the
fix/embed-datapart-api-misuse
branch
2 times, most recently
from
cd89b2b to
75bd0b0
Compare
| { | ||
| Mail::to('test@mail.com')->send($mailable = new EmbedDataMailable()); | ||
|
|
||
| $mailable->assertSeeInHtml('Embed data content: cid:foo.jpg'); |
Author
There was a problem hiding this comment.
cid is now automatically generated by DataPart as a random value, so it's been removed. Alternatively, should we just check for the existence of cid instead?
$mailable->assertSeeInHtml('Embed data content: cid:');Any better suggestions?
There was a problem hiding this comment.
From my point of view, yes we should check cid existence at least as you mentioned instead of removing the check totally.
Thanks
…filename, not cid
yinheli
force-pushed
the
fix/embed-datapart-api-misuse
branch
from
75bd0b0 to
6006207
Compare
Member
|
No associated issue or reproduction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect usage of the
DataPartconstructor inembed()andembedData()methods. The second parameter ofDataPartis filename, not Content-ID. DataPart generates its own Content-ID automatically.