[12.x] model:show command prompt for missing input with model suggestion #57671
+52
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dels trait for model interaction. Moved possibleModels method to the new trait for better code organization.
shaedrich
reviewed
Nov 5, 2025
| /** | ||
| * Prompt for missing input arguments using the returned questions. | ||
| * | ||
| * @return array |
Contributor
There was a problem hiding this comment.
You could narrow this further down
Suggested change
| * @return array | |
| * @return array<string, \Closure(): string> |
Member
|
Good stuff - thanks 👍 |
crynobone
added a commit
that referenced
this pull request
Nov 13, 2025
Regression issue introduced via #57671 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
added a commit
that referenced
this pull request
Nov 13, 2025
Regression issue introduced via #57671 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-attempt on #56674
Abstracted
possibleModelsintoInteractsWithModels.phptrait.