Skip to content

Conversation

@PhiloNL
Copy link
Contributor

@PhiloNL PhiloNL commented Nov 9, 2014

Fix for issue #6357

@GrahamCampbell GrahamCampbell changed the title [4.2] Fix validator incorrect error message when using arrays [4.2] Fix Incorrect Validator Error When Using Arrays Nov 11, 2014
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be exactly 2 spaces following this typehint, not 1.

@GrahamCampbell
Copy link
Collaborator

Is this actually a bug, or rather, a new feature? Should this go to 5.0, because it's a change in behaviour for people not expecting dots to behave like that.

@PhiloNL
Copy link
Contributor Author

PhiloNL commented Dec 17, 2014

Thanks, I'll fix the things you've mentioned.
I assume this is a bug, I've been using the dot notation to validate array input since 4.0
Which has always worked without any issue's.

$validator = Validator::make(
    Input::all(),
    array('foo[bar]' => 'required|image|max:4096') // Not even sure if the array notation would work at all.
);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then 3 spaces on that one. Sorry, didn't say earlier.

@GrahamCampbell
Copy link
Collaborator

Please squash to one commit.

@PhiloNL
Copy link
Contributor Author

PhiloNL commented Dec 17, 2014

Done!

@GrahamCampbell
Copy link
Collaborator

@taylorotwell What do you make of this btw?

taylorotwell added a commit that referenced this pull request Jan 2, 2015
[4.2] Fix Incorrect Validator Error When Using Arrays
@taylorotwell taylorotwell merged commit 69267db into laravel:4.2 Jan 2, 2015
@PhiloNL PhiloNL deleted the patch-1 branch January 2, 2015 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants