Fire event before cache is cleared to allow tasks to be performed before... #6615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore hand Signed-off-by: Ben James <in@benjam.es>
Collaborator
|
This isn't the correct place to put that call. What happens if the cache is cleared without going through the command? |
Contributor
Author
|
there is already an event fired in this file after the cache clears, so it seems logical to have an event fire before it. |
Collaborator
|
Hmmm. That event wasn't added by Taylor as such. I don't like that it was placed in the command. :( |
Collaborator
|
Reopening for review by Taylor. |
taylorotwell
added a commit
that referenced
this pull request
Dec 15, 2014
Fire event before cache is cleared to allow tasks to be performed before...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... hand
Signed-off-by: Ben James in@benjam.es