Allowing for camel and studly-cased mutator attributes

[janhartigan]

In this commit a previously undocumented feature of the mutator attributes was removed. Prior to this commit, it was possible to reference accessors using snake, camel, and studly cases. For example:

protected $appends = ['first_name', 'lastName', 'FullName'];

public function getFirstNameAttribute() {...}
public function getLastNameAttribute() {...}
public function getFullNameAttribute() {...}

This would work and append the key that you specified into the resulting array:

[
    'first_name' => ...,
    'lastName' => ...,
    'FullName' => ...,
]

After this commit, it only accepts snake case. I imagine we aren't the only ones using this (and we are using it rather widely in our systems), so I put together a pull request that keeps all the current features and allows for this. I added a test to verify that it works as well. Let me know if you need anything else or if you have any comments/questions/concerns.

[taylorotwell]

Ah. We'll merge this for 4.2 but remove it in 5.0 since it really makes the whole point of the optimization moot.

[janhartigan]

Cheers, thanks Taylor.

[GrahamCampbell]

:(

[janhartigan]

@GrahamCampbell sorry, I'll try to avoid this in the future :)

[andrewmclagan]

Just to clarify, we are not able to use camel case accessors or mutators in 5.x.x? Is there a workaround, currently in upgrade and current code style uses camel case?

[janhartigan]

Works fine for me. They merged this PR.

[andrewmclagan]

Yeah, i gave it a run and seems fine