[5.0] Move collect helper from foundation to support #7166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSilber
force-pushed
the
collect-helper
branch
2 times, most recently
from
f0e1441 to
12d4df3
Compare
Member
|
Conflicts? |
JosephSilber
force-pushed
the
collect-helper
branch
from
12d4df3 to
b3170dc
Compare
Contributor
Author
|
@taylorotwell rebased. |
Collaborator
|
👍 |
taylorotwell
added a commit
that referenced
this pull request
Jan 29, 2015
[5.0] Move collect helper from foundation to support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a side note: wouldn't it be great if we used this helper function throughout the codebase instead of just
newing up a collection? That way you can extend the base collection class, override this function, and all the collections returned from core will be your own extended implementation.Thoughts?