[5.0] Return collection from query builder #7169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
So you're 1000% sure this works this time? :) |
Contributor
Author
|
@GrahamCampbell Nothing is ever 100% sure, but you bet I double and triple checked this! And like I said, we now have the integration tests for a little more confidence 😄 |
Collaborator
|
Awesome. Laravel 5.0 will actually be launching on Monday/Tuesday next week, so there should be time to get this into the release. :) |
Contributor
Author
|
@GrahamCampbell this will probably conflict with this PR. Whichever one is merged first will require the other one to be rebased. I was holding off on this till that one got merged. I've had to rebase that thrice, but it still hasn't been merged, so I decided to throw this out here. Will rebase either one as needed. |
Collaborator
|
Right. :) |
Collaborator
|
@JosephSilber Yeh, please do resend this to 5.0. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really nice feature. The collection class is one of the best things in Laravel! It is also a boon for consistency.
This one does not touch the
getModelsmethod, or anything that has to do with relations or eager loading. In fact, it doesn't touch anything Eloquent related, so it's much safer.We also now have the integration tests, which really helps.