Skip to content

Conversation

@snjypl
Copy link
Contributor

@snjypl snjypl commented Jan 29, 2015

hasBeenBootstrapped and bootstrapWith method is missing in the application contract.

It's used in Illuminate\Foundation\Http\Kernal bootstrap method.
/**
* Bootstrap the application for HTTP requests.
*
* @return void
*/
public function bootstrap()
{
if ( ! $this->app->hasBeenBootstrapped())
{
$this->app->bootstrapWith($this->bootstrappers());
}
}

@RomainLanz
Copy link

You need to implements these functions.

@snjypl
Copy link
Contributor Author

snjypl commented Jan 29, 2015

The two methods are NOT present in the Application interface.

In the Illuminate\Foundation\Http/Kernal class's bootstrap method

we are calling hasBeenBootstrapped and bootstrapWith on the application object
which is expected to implement Illuminate\Contracts\Foundation\Application Interface.

@snjypl
Copy link
Contributor Author

snjypl commented Jan 29, 2015

can anyone please help me with the build failure?

@snjypl snjypl changed the title Added missing methods in Application Contract. [5.0] Added missing methods in Application Contract. Jan 29, 2015
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace.

@GrahamCampbell
Copy link
Collaborator

This doesn't work.

@snjypl
Copy link
Contributor Author

snjypl commented Feb 9, 2015

I guess, this should be considered a BUG.

As i have explained earlier, kernal class cannot called the two methods which are not defined in the interface

Have reported it as an issue:

#7344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants