[5.0] QueryBuilder runSelect method refactoring

[alexandre-butynski]

It's just a small refactoring. This method presents an obvious duplication, it could be simplified.

In addition, useWritePdo attribute could be renamed useReadPdo to be more consistent with the Connection class. Or, because the function useWritePdo() has a good name, maybe all the logic could be reversed in the Connection class... I can't make my mind up but that's not really important anyway !

Note : proposed to 5.0 as asked in #7175 but could also be merged in 4.2.

[GrahamCampbell]

Please rebase this.

[alexandre-butynski]

That's done. Sorry for this bad commit, GitHub has misled me by showing me a clean diff in its pull request interface.

[GrahamCampbell]

Please send this to the 5.0 branch rather than 5.1.

[JosephSilber]

@GrahamCampbell are all existing PRs to be retargeted at 5.0?

[GrahamCampbell]

@GrahamCampbell are all existing PRs to be retargeted at 5.0?

I'll be dealing with that where relevant, yeh.

[JosephSilber]

@GrahamCampbell I'm asking because I have 2 outstanding PRs. Should I close them and resubmit against 5.0?

[GrahamCampbell]

Should I close them and resubmit against 5.0?

I'll have to check what they are. I'll either be retargeting them, or just marking them as 5.1.

[GrahamCampbell]

@JosephSilber Give me 15 mins or something to get around to them. :)

[GrahamCampbell]

Rebased and moved to #7209.

[alexandre-butynski]

Thanks a lot, it seems that Laravel moves too fast for me these days !

[GrahamCampbell]

Things are a moving about quite a bit this week and next more than normal. :)

[RomainLanz]

It announces good news 😄

[GrahamCampbell]

NB 5.0.0 will ship early next week.