Update phpDoc to use Fully Qualified Class Name #720
Conversation
PR for Issue #701 Changes phpDoc namespace to FQN, following the official phpdoc documentation: http://phpdoc.org/docs/latest/for-users/types#valid-class-name
I can't tell from the web interface what is going on (my first guess is tabs vs spaces) but for files like Also if we're going to do all of these changes might it be wise to also consider either removing |
Hmm, I'm not sure. All I did was replace all |
} | ||
|
||
} | ||
<?php namespace Illuminate\Workbench; |
bencorlett
Mar 27, 2013
Contributor
What's with half of these files files having EVERY line changed?!
What's with half of these files files having EVERY line changed?!
|
||
} | ||
|
||
} |
bencorlett
Mar 27, 2013
Contributor
And here
And here
barryvdh
Mar 27, 2013
Author
Contributor
Yeah sorry, I just did a couple of find and replaces in notepad++ and
committet them. Don't know why github thinks I changed all those lines.
Op 27 mrt. 2013 22:05 schreef "Ben Corlett" notifications@github.com het
volgende:
In src/Illuminate/View/ViewServiceProvider.php:
-
- * @param Illuminate\Foundation\Application $app
- * @return bool
- */
- public function sessionHasErrors($app)
- {
- $config = $app['config']['session'];
-
if (isset($app['session']) and ! is_null($config['driver']))
-
{
-
return $app['session']->has('errors');
- }
- }
-}
And here
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/720/files#r3560166
.
Yeah sorry, I just did a couple of find and replaces in notepad++ and
committet them. Don't know why github thinks I changed all those lines.
Op 27 mrt. 2013 22:05 schreef "Ben Corlett" notifications@github.com het
volgende:
In src/Illuminate/View/ViewServiceProvider.php:
- * @param Illuminate\Foundation\Application $app
- * @return bool
- */
- public function sessionHasErrors($app)
- {
- $config = $app['config']['session'];
if (isset($app['session']) and ! is_null($config['driver']))
{
return $app['session']->has('errors');
- }
- }
-}
And here
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/720/files#r3560166
.
bencorlett
Mar 27, 2013
Contributor
GitHub isn't thinking you've changed all those files, git is. Which means you have :P.
Try a decent editor like Sublime Text 2 :) But see my other comment.
GitHub isn't thinking you've changed all those files, git is. Which means you have :P.
Try a decent editor like Sublime Text 2 :) But see my other comment.
Anahkiasen
Mar 27, 2013
Contributor
I'm thinking indentation issues.
I'm thinking indentation issues.
You really need to re-do this PR to be honest. That issue with every line being changed in half of the files is no good. However, I'm not sure if your'e wasting your time or not. There was an issue open which Taylor has closed (which you've referred to in your PR, #701). I don't like your chances of having it merged. The idea of proposals & issues before-hand is to see the likelihood of something getting merged, so you don't feel you've wasted all your time if it doesn't. |
I know Taylor closed this, but the reason was that using local classnames And I did try to do it with Sublime Text just now, but got the same result. So I'm going to let Taylor decide what he want to do with it. It's an easy search&replace action, so it doesn't have to be this PR. |
It may be something to do with encoding or your git configuration. Are you on a PC by any chance?
|
Yes, Windows 8 with Github for Windows, with a fresh install of Sublime Text 2 |
Hmm. yeah I've seen people have issues with windows, line endings and encoding. I'm on a mac so I'm not much help.
|
I've found it necessary to tell git explicitly that .php files (among others) are text in order to get the diffs correct #~/.gitattributes_global
*.csv text
*.ttl text
*.php text
*.inc text
*.md text
*.markdown text
*.xsl text This page: https://help.github.com/articles/dealing-with-line-endings#platform-windows This is a good fix for those few of us NOT using Sublime. :-) But it would probably be good to try to get a formal proposal accepted since it affects a lot of files. |
I'm not comfortable merging this with those entire file replacements being shown in the diff. |
Done. |
Thanks! |
To be totally correct, all the Symfony and other classes should also be prefixed with a , but perhaps that is for a future time ;) |
submit |
PR for Issue #701 Changes phpDoc namespace to FQN, following the
official phpdoc documentation:
http://phpdoc.org/docs/latest/for-users/types#valid-class-name