[5.0] Change "\n" to PHP_EOL in 3 tests to make them pass on windows. #7237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'd argue doing it like this is actually better, because it should work no matter what Git's |
Collaborator
|
I actually changed them to \n a while ago. I have windows set to use unix style newline endings. I'd recommend everyone to do this. |
Contributor
|
While I would totally recommend that, too, people will obviously not change their Git settings just so that Laravel's unit tests pass. So why not put the line endings in the strings verbatim as you did for some of the other tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 3 tests are not passing in windows. This commit fixes it.