New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zray requires string literal to enable #805

Closed
Fuxy22 opened this Issue Feb 6, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@Fuxy22

Fuxy22 commented Feb 6, 2018

Please note that the Homestead issue tracker is reserved for bug reports and enhancements. We are not always able to debug Vagrant, Provider or Operating System issues, but will do our best to help. Thank you!

Versions

  • Vagrant: 2.01
  • Provider: Virtualbox
  • Homestead: 7.1.0

Host operating system

Linux Mint 17

Homestead.yaml

sites:
    - map: labelprint.io
      to: /home/vagrant/Code/labelprint/public
      schedule: true
      zray: 'true'

Expected behavior

Homestead.yaml would take a boolean to enable or disable zray

Actual behavior

Z-ray setting requires a string instead.

Steps to reproduce

  1. Set zray setting as boolean
  2. Receive below error:
Bringing machine 'homestead-7' up with 'virtualbox' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:

shell provisioner:
* Shell provisioner `args` must be a string or array.

Note: This can be a config breaking change so I'm no certain how you want to handle it.

@svpernova09

This comment has been minimized.

Member

svpernova09 commented Feb 6, 2018

Thanks for opening an issue.

This is working as intended for the moment. Z-Ray is a new feature that I can see users wanting to turn off and on and requiring the string makes it easy to say 'true' or 'false' without having to completely remove the line from Homestead.yaml

@svpernova09 svpernova09 closed this Feb 6, 2018

@Fuxy22

This comment has been minimized.

Fuxy22 commented Feb 6, 2018

It's a bit confusing / counter intuitive. Might need to be pointed out in the docs then.

@svpernova09

This comment has been minimized.

Member

svpernova09 commented Feb 6, 2018

Here's a quick up and running doc on Z-Ray until we can get something into the official docs: https://www.joeferguson.me/homestead-welcomes-z-ray-by-zend/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment