Allow numeric ports for proxy sites #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #910 by casting the port to a string and therefore allowing string concatenation in [z-ray cleanup](https://github.com/laravel/homestead/blob/master/scripts/homestead.rb#L269) It's probable that this will occur in other places, i will look around, but in the meantime, this fixes the most common scenario that is a fresh installation with its defaults.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #910 by casting the port to a string and therefore allowing string concatenation in z-ray cleanup
This enables
{ "map": "homestead.test", "to": 8080, "type": "proxy" }and keeps:
{ "map": "homestead.test", "to": "8080", "type": "proxy" }It's probable that this will occur in other places, i will look around, but in the meantime, this fixes the most common scenario that is a fresh installation with its defaults.