Eliminate use of transaction so it can be used w/sentinel (via predis) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While no longer failing w/exception, metric collection is still not working properly w/sentinel. Within metrics dashboard, job names are missing initial characters and queue names show "false". Seems smembers within measuredJobs/measuredQueues is not including the prefix that substr is stripping.... Edit: covered/repaired in #196. Happened to be triggered by not establishing default prefix in sentinel config of horizon connection. |
Repair assumption about default key prefix length
|
There is other things here besides the transaction. Please only do one thing per PR. |
|
Sorry - wasn't aware this PR got modified when I promoted fix for #196 on my fork (I need both changes locally). Will resubmit this change in isolation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #193. Eliminates use of transaction for straight read/delete. High availability is far more important to me than ensuring accuracy of stats, which I think would be the only possible side effect of the removal.