Update composer path on findComposer #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen PR #85.
Changed log
NewCommand::findComposercommand.Actually, the original
php compoer.pharstring result is not correct.And this will not specify the current path to let PHP binary know where the
composer.pharcan execute.It should use the current
composerpath to tell PHP binary to executecomposer.phar.Instruction
Environment
1.8.4.Here are steps about reproducing the issue.
composer require laravel/installercommand.vendor/bin/laravel new blogto create the new Laravel project.