Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c222f6d
commit 0bec06c
Showing
3 changed files
with
8 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0bec06c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you remove all these defination comments? I just upgraded to 7x and now all of a sudden ive this new config file and no idea what going on! The upgrade guide only barely just mentions it.
perhaps you could please put the link in comments to refer to the options?
https://github.com/fruitcake/laravel-cors
0bec06c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rah1x you own this file. Feel free to re-add them.
0bec06c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's IMHO besides the point, I'm with @Rah1x and would prefer to keep them.
Here's, at least my, reasoning:
But this clashes a bit here, even if I add them back, any feature attempt to sync will show as changed
I've done this successfully on projects starting with 5.1 and now being on L8 and usually incrementally changes and slight deviations are easy to handle (and usually only have to be done twice a year, when upgrades happen, so it's "manageable").
There's really no technical merit for removing any of this, and to put it into the words of Taylor: those comments and the ones from the other config files are just beautiful! (and useful)
0bec06c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to keep a consistent code styling across our files, sorry.
0bec06c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you're saying, would the comments have been like this they could have stayed?
0bec06c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've already updated the comments to our new styling and probably won't be changing anything here sorry. If you want the old style feel free to copy them from the fruitcake repo.