Permalink
Browse files

update config

  • Loading branch information...
taylorotwell committed Dec 5, 2015
1 parent ba7137d commit 2adbbbd91e9d6e2d569cc56f138b7273efe25651
Showing with 0 additions and 3 deletions.
  1. +0 −3 config/app.php
@@ -113,7 +113,6 @@
/*
* Laravel Framework Service Providers...
*/
Illuminate\Foundation\Providers\ArtisanServiceProvider::class,
Illuminate\Auth\AuthServiceProvider::class,
Illuminate\Broadcasting\BroadcastServiceProvider::class,
Illuminate\Bus\BusServiceProvider::class,
@@ -164,7 +163,6 @@
'Artisan' => Illuminate\Support\Facades\Artisan::class,
'Auth' => Illuminate\Support\Facades\Auth::class,
'Blade' => Illuminate\Support\Facades\Blade::class,
'Bus' => Illuminate\Support\Facades\Bus::class,
'Cache' => Illuminate\Support\Facades\Cache::class,
'Config' => Illuminate\Support\Facades\Config::class,
'Cookie' => Illuminate\Support\Facades\Cookie::class,
@@ -175,7 +173,6 @@
'File' => Illuminate\Support\Facades\File::class,
'Gate' => Illuminate\Support\Facades\Gate::class,
'Hash' => Illuminate\Support\Facades\Hash::class,
'Input' => Illuminate\Support\Facades\Input::class,

This comment has been minimized.

@Gawdl3y

Gawdl3y Dec 22, 2015

Contributor

The removal of this facade by default should probably be noted somewhere, if not the 5.2 upgrade guide. This is a breaking change if someone creates a fresh 5.2 install and copies code over, as I did. I know of one package that relies on it, as well (the ReCAPTCHA package).

This comment has been minimized.

@ytake

ytake Dec 22, 2015

Contributor

third party packages should not be dependent on the facade.

This comment has been minimized.

@Gawdl3y

Gawdl3y Dec 22, 2015

Contributor

You're absolutely correct, and I'm probably going to be contributing a fix to that package. The effect on actual applications, however, is still present.

This comment has been minimized.

@crynobone

crynobone Dec 22, 2015

Contributor
$challenge = app('Input')->get($captcha->getResponseKey());

This is wrong at so many level. app('request')->input() would do the trick.

The effect on actual applications, however, is still present.

Your application is owned by you and you could readd the alias if you wish. (Only the alias is removed, the Illuminate\Support\Facades\Input class is still available (and still not marked as deprecated).

But yes, the upgrade guide should have mention this.

This comment has been minimized.

@Gawdl3y

Gawdl3y Dec 22, 2015

Contributor

Yep, I've already submitted a pull request to fix it in that package (greggilbert/recaptcha#98). And a mention in the upgrade guide is what I recommend as well, I'm not advocating for alias' return.

This comment has been minimized.

@GrahamCampbell

GrahamCampbell Jan 6, 2016

Member

No packages should ever assume aliases exist.

'Lang' => Illuminate\Support\Facades\Lang::class,
'Log' => Illuminate\Support\Facades\Log::class,
'Mail' => Illuminate\Support\Facades\Mail::class,

1 comment on commit 2adbbbd

@cat5inthecradle

This comment has been minimized.

Copy link

cat5inthecradle commented on 2adbbbd Jan 6, 2016

Seconding that it be mentioned in the upgrade guide the removal of ArtisanServiceProvider. We also had to remove ContainerServiceProvider from our app.php, but that gave us a friendly error and we were easily able to find it.

Please sign in to comment.