New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web.php #4400

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Artiik-fr

Artiik-fr commented Aug 31, 2017

Use the new Route::view method from Laravel 5.5

@fletch3555

This comment has been minimized.

fletch3555 commented Aug 31, 2017

There have literally been 50 PRs for this already, and they have all been declined so far. I assure you, yours will be no different.

@antonkomarev

This comment has been minimized.

antonkomarev commented Aug 31, 2017

I will just leave it here: #4398 #4396 #4391 #4386 #4381 #4310 #4378

@Artiik-fr Artiik-fr closed this Aug 31, 2017

@antonkomarev

This comment has been minimized.

antonkomarev commented Aug 31, 2017

It will be easier to add commented out Route::view helper in routes and keep one more route with closure for tests to stop this types of PRs in future :}

// Route::view('/', 'welcome');

Route::get('/', function () {
    return view('welcome');
});
@joshmanders

This comment has been minimized.

Contributor

joshmanders commented Aug 31, 2017

@GhazanfarMir

This comment has been minimized.

GhazanfarMir commented Sep 1, 2017

@a-komarev and then expect even more PRs to remove one of the two :)

@antonkomarev

This comment has been minimized.

antonkomarev commented Sep 1, 2017

@GhazanfarMir this will happen with possiblity of 0.0000001% and now we are getting PRs with Route::view each day. #4401 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment