New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example Route::view #4401

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@brayniverse
Contributor

brayniverse commented Sep 1, 2017

Maybe this will help reduce the number of Pull Requests you're getting for changing the default route. 馃槅

@kamui545

This comment has been minimized.

kamui545 commented Sep 1, 2017

Thanks to those PRs I learned the existence of this feature 馃槀

@antonkomarev

This comment has been minimized.

antonkomarev commented Sep 1, 2017

@brayniverse as for me thats the only way to stop this kind of PRs :} Proposed that recently too: #4400 (comment)

@antonkomarev antonkomarev referenced this pull request Sep 1, 2017

Closed

Update web.php #4400

@joshmanders

This comment has been minimized.

Contributor

joshmanders commented Sep 1, 2017

Or just submit a CONTRIBUTING.md file to the repo that is populated into the PR comment box that references 30 of the 500 bajillion PR's stating that it's not going to get accepted.

@m1guelpf

This comment has been minimized.

Contributor

m1guelpf commented Oct 1, 2017

@joshmanders I can see a problem with that:

  • How can we add that file, while keeping it away from new laravel installations.
@joshmanders

This comment has been minimized.

Contributor

joshmanders commented Oct 1, 2017

@m1guelpf put it in .github and have a postinstall that removes that directory.

@antonkomarev

This comment has been minimized.

antonkomarev commented Oct 1, 2017

I don't see any problem with adding contributions file, personally I'm adding it in all my repositories. But on practice tiny percent of people reading it.

@m1guelpf

This comment has been minimized.

Contributor

m1guelpf commented Oct 1, 2017

The only think I can see this viable is by creating bot that checks the diff for this change and closes it.

@m1guelpf

This comment has been minimized.

Contributor

m1guelpf commented Oct 1, 2017

Any other way would suppose adding a file to every Laravel installation

@antonkomarev

This comment has been minimized.

antonkomarev commented Oct 1, 2017

No. You can add export-ignore CONTIRUBUTING.md in .gitattributes file and it will present only in dev environment.
Here is an example: https://github.com/cybercog/laravel-ban/blob/master/.gitattributes

@joshmanders

This comment has been minimized.

Contributor

joshmanders commented Oct 1, 2017

^ perfect.

@veekthoven

This comment has been minimized.

veekthoven commented on 9e9c519 Oct 1, 2017

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment