New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route view helper for welcome page. #4439

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@SidharthRaveendran

SidharthRaveendran commented Oct 1, 2017

Used the Laravel 5.5 route helper for views.

Sid
@JulienGelmar

This comment has been minimized.

@m1guelpf

This comment has been minimized.

Contributor

m1guelpf commented Oct 1, 2017

@KristofMorva

This comment has been minimized.

Contributor

KristofMorva commented Oct 1, 2017

Sometimes I feel it'd be easier for the Laravel team if they just disabled PRs for this repo :D

@SidharthRaveendran

This comment has been minimized.

SidharthRaveendran commented Oct 1, 2017

That would beat the whole purpose of having Laravel in github won't it.

@brunogaspar

This comment has been minimized.

Contributor

brunogaspar commented Oct 1, 2017

Sometimes I feel it'd be easier for the Laravel team if they just disabled PRs for this repo :D

Even if they would want to disable pull requests, that's not possible in GitHub, only issues can be disabled.


As others already suggested, i would prefer to see both examples on the web.php, where one of which would be commented out, because these type of pull requests will never cease to exist unfortunately, since people rarely uses the search functionality.

@KristofMorva

This comment has been minimized.

Contributor

KristofMorva commented Oct 1, 2017

@SidharthRaveendran @brunogaspar I wasn't serious certainly :P

@brunogaspar the problem is, that way we should make examples in the source for like every method of Route. Also even if we do that, the same event will happen all over again when new features are introduced, because the core of the problem will remain - people use GitHub before learning how to use it. It's a far fetched thing, but I think GitHub could actually show a warning about possible duplicates before submitting a PR (based on title / changes / etc).

@antonkomarev

This comment has been minimized.

antonkomarev commented Oct 1, 2017

Calling @taylorotwell! Taylor, maybe you'd approve PR #4401 which adds an example to route file to stop this duplications, please?
Sorry for direct call, but I don't see another way to solve this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment