Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Enable JS on StyleCI #5000

Merged
merged 12 commits into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@GrahamCampbell
Copy link
Member

commented Apr 23, 2019

No description provided.

GrahamCampbell added some commits Apr 23, 2019

@driesvints

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

We've decided against this for now for exactly the change on the webpack.mix.js file.

@driesvints driesvints closed this Apr 23, 2019

@driesvints driesvints deleted the js branch Apr 23, 2019

@GrahamCampbell GrahamCampbell restored the js branch Apr 23, 2019

@GrahamCampbell

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

Let me see if we can avoid that.

GrahamCampbell added some commits Apr 23, 2019

GrahamCampbell added some commits Apr 23, 2019

@driesvints

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@GrahamCampbell can you maybe do this on a fork? (see all the auto-fixes by StyleCI)

Notification overload for me atm 😅

@driesvints driesvints closed this Apr 23, 2019

@driesvints driesvints deleted the js branch Apr 23, 2019

@GrahamCampbell GrahamCampbell restored the js branch Apr 23, 2019

@GrahamCampbell

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

It's ready now. :)

@@ -6,4 +6,9 @@ php:
not-name:
- index.php
- server.php
js:
print-width: 100

This comment has been minimized.

Copy link
@driesvints

driesvints Apr 23, 2019

Member

Let's remove this one to stick to the default like we do for all other repos.

This comment has been minimized.

Copy link
@GrahamCampbell

GrahamCampbell Apr 23, 2019

Author Member

If we leave it at 120, 3 other files will be changed I think?

This comment has been minimized.

Copy link
@driesvints

driesvints Apr 23, 2019

Member

I don't think so? Wasn't the case when I enabled it.

@driesvints

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Can you also squash your commits?

@driesvints driesvints changed the title Enable JS on StyleCI [5.8] Enable JS on StyleCI Apr 23, 2019

@taylorotwell taylorotwell merged commit 60db703 into master Apr 23, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
@taylorotwell

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Squashed and merged.

@GrahamCampbell GrahamCampbell deleted the js branch Apr 24, 2019

@GrahamCampbell

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.