Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude StyleCI config from exported files #5012

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
3 participants
@roberto-aguilar
Copy link
Contributor

commented Apr 29, 2019

I noticed that this file was being included when i ran the laravel new command and even though some developers will run StyleCI, the purpose of this file seems more like it ensures the repository quality rather than providing an starting point for this service.

On the other hand, this are really good defaults so i'm open minded about this, just wanted to make sure this wasn't an oversight 馃槂

Exclude StyleCI config from exported files
I noticed that this file was being included when i ran the
`laravel new` command and even though some developers will run StyleCI,
the purpose of this file seems more like it ensures the repository
quality rather than providing an starting point for this service.

@taylorotwell taylorotwell merged commit a6bf241 into laravel:master Apr 29, 2019

1 check passed

continuous-integration/styleci/pr The analysis has passed
Details

@roberto-aguilar roberto-aguilar deleted the roberto-aguilar:feature/exported-files branch Apr 29, 2019

driesvints added a commit that referenced this pull request Apr 30, 2019

@driesvints

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

FYI: I've reverted this. This caused the entry to be added to the .gitattributes file in every Laravel install. Instead we'll strip out the file in the cabinet installs soon.

@roberto-aguilar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Understood, thanks @driesvints!

Reference: laravel/installer@67ba1ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.