Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Update number of Laracasts videos #5063

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@ryanpurcella
Copy link
Contributor

commented Jul 17, 2019

Commit updates the number of available Laracasts videos. As of this writing there are 1506 videos.

Ryan Purcella
@antonkomarev

This comment has been minimized.

Copy link

commented Jul 17, 2019

Maybe it's better to rephrase this sentence to not update it all the time?

@ludo237

This comment has been minimized.

Copy link

commented Jul 18, 2019

Over 1400 is still correct, old PR were closed because the sentence is still correct even with 1506 videos

@GuidoHendriks

This comment has been minimized.

Copy link

commented Jul 18, 2019

Maybe only update at values like 1500/2000.

@driesvints driesvints changed the title Update number of Laracasts videos [5.8] Update number of Laracasts videos Jul 18, 2019

@ryanpurcella

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

Perhaps update now because 1500 is a nice rounded number? Once 2000 is reached, the sentence can be reworded to "Laracasts contains thousands of video tutorials on a range of topics including Laravel, modern PHP, unit testing, and JavaScript." This wording would probably be just as impressive as an actual number. Otherwise, 500 level increments sounds good to me.

@taylorotwell taylorotwell merged commit f73795a into laravel:master Jul 18, 2019

1 check passed

continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.