Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Allowing optional use of yml/yaml file extensions in .editorconfig #5090

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@darrencraig
Copy link
Contributor

commented Sep 3, 2019

The YAML docs generally recommends using .yaml as the preferred extension for YAML files - https://yaml.org/faq.html.

I've tweaked the .editorconfig to set both yaml and yml files to have the same indentation. Without this, *.yaml files default to 4 spaces.

@driesvints

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Can you send this to 6.0 branch instead?

@driesvints driesvints closed this Sep 3, 2019

@darrencraig

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Can you send this to 6.0 branch instead?

Is that the develop branch? There doesn't appear to be a public 6.0 branch?

@driesvints driesvints reopened this Sep 3, 2019

@driesvints

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Ow, sorry. Mistook this with the framework repo 🤦‍♂

@driesvints driesvints changed the title Allowing optional use of yml/yaml file extensions in .editorconfig [6.x] Allowing optional use of yml/yaml file extensions in .editorconfig Sep 3, 2019

@taylorotwell taylorotwell merged commit 65959b2 into laravel:master Sep 3, 2019

1 check passed

continuous-integration/styleci/pr The analysis has passed
Details

@darrencraig darrencraig deleted the darrencraig:add-yaml-to-editorconfig branch Sep 3, 2019

pjona added a commit to pjona/lumen that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.