Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add 'null' logging channel #5106

Merged
merged 4 commits into from Sep 13, 2019
Merged

[6.x] Add 'null' logging channel #5106

merged 4 commits into from Sep 13, 2019

Conversation

rogervila
Copy link
Contributor

As proposed on laravel/ideas#1806, this implementation ads a 'none' logging channel which outputs logs to nowhere by using Monolog's 'NullHandler' class.

@driesvints driesvints changed the title Add 'none' logging channel [6.x] Add 'none' logging channel Sep 13, 2019
@taylorotwell
Copy link
Member

Why not "null" like the other "null" drivers?

@rogervila
Copy link
Contributor Author

Why not "null" like the other "null" drivers?

I agree. Consistency is important here

@rogervila rogervila changed the title [6.x] Add 'none' logging channel [6.x] Add 'null' logging channel Sep 13, 2019
@fitztrev
Copy link

In another PR, a string value of "null" (for broadcast driver) caused issues and @taylorotwell hinted at removing.

I think going forward into future Laravel versions we may want to consider offering an alternative to "null" for these drivers. Even if we still support null, having another name that doesn't have this kinds of problems would be nice.

laravel/framework#27691 (comment)

@taylorotwell taylorotwell merged commit c70c986 into laravel:master Sep 13, 2019
realodix added a commit to realodix/urlhub that referenced this pull request Sep 14, 2019
@driesvints
Copy link
Member

FYI: this doesn't works with Monolog 2: laravel/framework#30026

@rogervila
Copy link
Contributor Author

FYI: this doesn't works with Monolog 2: laravel/framework#30026

Thank you @driesvints
I will try to work on a PR in order to fix it.

@driesvints
Copy link
Member

@rogervila there's already one: laravel/framework#30123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants