Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Password confirmation #5129

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@driesvints
Copy link
Member

commented Oct 8, 2019

These changes along with the new password confirmation functionality and the new password rule. See laravel/framework#30214

I've also removed the "guest" middleware from the password reset controllers so users can reset their password while logged in. This was needed in combination with the new password confirmation screen. See laravel/ui#34

driesvints added 3 commits Oct 8, 2019
It's not necessary for the user to be logged out when resetting their password. This allows users to reset their password while logged in. Can be used in combination with the new RequiresPassword middleware.
@driesvints driesvints changed the title Password confirmation [6.x] Password confirmation Oct 8, 2019
@antonkomarev

This comment has been minimized.

Copy link

commented Oct 8, 2019

@driesvints isn't it targeted to 7.x branch?

Edit: Sorry, it's not framework repository, so master branch here is not 7.x.

@driesvints

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

@antonkomarev no there's nothing breaking here.

@taylorotwell taylorotwell merged commit ba3aae6 into laravel:master Oct 8, 2019
1 check passed
1 check passed
continuous-integration/styleci/pr The analysis has passed
Details
@driesvints driesvints deleted the driesvints:password-confirmation branch Oct 8, 2019
realodix added a commit to realodix/urlhub that referenced this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.