diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 58d9c0b9d..c88a3f34d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,7 +16,7 @@ jobs: strategy: fail-fast: true matrix: - php: [8.1, 8.2, 8.3] + php: [8.1, 8.2] laravel: [10] driver: [swoole, openswoole] diff --git a/src/Commands/StartRoadRunnerCommand.php b/src/Commands/StartRoadRunnerCommand.php index 65665a8be..39b5872df 100644 --- a/src/Commands/StartRoadRunnerCommand.php +++ b/src/Commands/StartRoadRunnerCommand.php @@ -13,8 +13,8 @@ class StartRoadRunnerCommand extends Command implements SignalableCommandInterface { use Concerns\InstallsRoadRunnerDependencies, - Concerns\InteractsWithEnvironmentVariables, - Concerns\InteractsWithServers; + Concerns\InteractsWithServers, + Concerns\InteractsWithEnvironmentVariables; /** * The command's signature. diff --git a/src/Commands/StartSwooleCommand.php b/src/Commands/StartSwooleCommand.php index a990ede07..5038df84d 100644 --- a/src/Commands/StartSwooleCommand.php +++ b/src/Commands/StartSwooleCommand.php @@ -12,7 +12,7 @@ class StartSwooleCommand extends Command implements SignalableCommandInterface { - use Concerns\InteractsWithEnvironmentVariables, Concerns\InteractsWithServers; + use Concerns\InteractsWithServers, Concerns\InteractsWithEnvironmentVariables; /** * The command's signature. diff --git a/src/RoadRunner/Concerns/FindsRoadRunnerBinary.php b/src/RoadRunner/Concerns/FindsRoadRunnerBinary.php index 9db9d4b11..d1e69d2fd 100644 --- a/src/RoadRunner/Concerns/FindsRoadRunnerBinary.php +++ b/src/RoadRunner/Concerns/FindsRoadRunnerBinary.php @@ -9,6 +9,8 @@ trait FindsRoadRunnerBinary { /** * Find the RoadRunner binary used by the application. + * + * @return string */ protected function findRoadRunnerBinary(): ?string { diff --git a/src/SymfonyProcessFactory.php b/src/SymfonyProcessFactory.php index 96b4f5417..5a52a265d 100644 --- a/src/SymfonyProcessFactory.php +++ b/src/SymfonyProcessFactory.php @@ -9,6 +9,8 @@ class SymfonyProcessFactory /** * Create a new Symfony process instance. * + * @param string $cwd + * @param array $env * @param mixed|null $input * @return \Symfony\Component\Process\Process */ diff --git a/src/Worker.php b/src/Worker.php index d3b1e33d1..42a2fcca6 100644 --- a/src/Worker.php +++ b/src/Worker.php @@ -59,6 +59,8 @@ public function boot(array $initialInstances = []): void /** * Handle an incoming request and send the response to the client. + * + * @param \Laravel\Octane\RequestContext $context */ public function handle(Request $request, RequestContext $context): void { @@ -179,6 +181,8 @@ public function handleTick(): void /** * Handle an uncaught exception from the worker. + * + * @param \Laravel\Octane\RequestContext $context */ protected function handleWorkerError( Throwable $e,