[11.x] Auth Query optimization for api calls #1433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changed revoked function in ClientRepository, now it will accept client instance instead of id (-1 query in db) 2. Changed Token guard to fit logic I mentioned before 3. PSR now will be passed from function instead of making 2 queries now we will be making only 1 query 4. Removed ->with(1) from revoked from clients mock in Token Guard Tests
driesvints
changed the title
|
No plans to change this atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While logging database queries I saw that there were 5 queries such as:
2 queries to
oauth_clientstable3 queries to
oauth_access_tokenstable (2 of which were made byleague/oauth2-serverpackage)In order to reduce number of queries some changes in code where made:
revokedfunction in ClientRepository now will accept client as parameter instead of ID (this removes 1 query tooauth_clientstable). Client object that is passed to this function is returned from findActive function in ClientRepository. To fit those changes I have removed->with(1)from clients mock in TokenGuardTests (revoked).getPsrRequestViaBearerTokenfunction in TokenGuard that returns some result fromleague/oauth2-servernow will be passed as parameter tohasValidProviderand from there toclientfunction in TokenGuard (this process removes 1 query from 3 total queries made tooauth_access_tokenstable)Changes that were made in this pull request will remove 2 queries out of 5, bringing down number of total queries on each request from 5 to 3.