Skip to content

Conversation

@nandi95
Copy link
Contributor

@nandi95 nandi95 commented Nov 25, 2025

It would be nice if the ->activate() didn't create multiple queries when it can be one.
This is a breaking change due to interface changing breaking somebody's implementation.
I could not test it as I was getting:

Illuminate\Database\QueryException: could not find driver (Connection: testing, SQL: select exists (select 1 from "main".sqlite_master where name = 'migrations' and type = 'table') as "exists")

So I'm just pushing it up to see what happens in CI. Also good to get some feedback early.

@taylorotwell
Copy link
Member

Hey there! We can't change interfaces in patch release.

@nandi95
Copy link
Contributor Author

nandi95 commented Nov 26, 2025

@taylorotwell As I expected. However, can we release a new major version? Or Perhaps it can go on a release branch for the next major version?

@timacdonald
Copy link
Member

I've opened #157 which should allow us to add this feature in 1.x.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants