Skip to content

Conversation

@freshleafmedia
Copy link
Contributor

This PR removes the Aloglia dev dependency.

I believe this is a good idea for a number of reasons:

  • While many developers will be using Algolia with this package it isn't a requirement
  • If the Algolia package is missing and you attempt to use the Algolia engine an exception is thrown which explains what to do. See src/EngineManager.php#L54
  • Having it as a dev dependency means it's possible for an application to work in a local environment where dev packages are installed but when deployed to a production environment, where dev dependencies aren't installed, it will break.
  • It allows [8.x] PHP 8 Support #425 to be merged

@freshleafmedia freshleafmedia changed the title Removes Algolia dev dependency Removes Algolia Dev Dependency Dec 8, 2020
@driesvints
Copy link
Member

Algolia is the main search engine for this package and without shipping it Scout would basically be an empty shell. We have no intention on removing it as the default. Also, this PR is a breaking change on a current stable release.

I know everyone's waiting for PHP 8 support in Scout but there's nothing we can do but wait until Algolia ships PHP 8 support on their package.

@driesvints driesvints closed this Dec 8, 2020
@driesvints
Copy link
Member

driesvints commented Dec 8, 2020

I'm sorry, I'm incorrect. This indeed wouldn't be a breaking change. And this indeed doesn't seems to have such a big impact, strange.

I'll consider this PR a bit today before I reopen this. Thanks

@freshleafmedia
Copy link
Contributor Author

Thanks. In my use case I'm using Scout without Algolia so the dependency doesn't make sense and is also limiting my ability to use PHP 8.

@driesvints
Copy link
Member

I'm sorry I didn't get to this again. I'll come back to this later this week.

@driesvints driesvints reopened this Dec 10, 2020
@driesvints driesvints merged commit ae960d1 into laravel:8.x Dec 10, 2020
@driesvints
Copy link
Member

@freshleafmedia thanks for this 👍

@freshleafmedia freshleafmedia deleted the feature/remove-algolia-dependency branch December 10, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants