Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
PHP 5.6 updates to address MySQL password expiration #82
I'm currently using Homestead 2 and https://atlas.hashicorp.com/laravel/boxes/homestead/versions/0.3.3 which recently got hit by the homestead user's password expiring in mysql 5.7 per http://stackoverflow.com/q/40493594/134335.
As I worked through what I thought would be just simply implementing PR's #59 and #60, I realized it required much more work due to
There are a few changes I could've made that I'm a little unsure about:
I didn't know if this should be as close to 1:1 with master as possible, though I personally err on that side of things.
This also requires a tandem patch to Homestead v2 as
I followed the notes from #59 as closely as possible. I tested for the expiration and it is no longer a problem. I made sure I could produce at least 2 builds in a row before calling it done but ultimately produced about 4-5 without failure . I tested a few separate Laravel projects and saw no noticeable awkwardness but these are very rudimentary projects with no redis usage nor would I know what to look for if some of the php extensions are somehow broken. The gist of my latest build is https://gist.github.com/w0rd-driven/f1cfb4b9577ffd391462ba7cbf4c0c8e.
Lastly, I made one improvement that could make it back into master. I moved the xdebug cli disable above pulling in laravel envoy and installer as the provisioning could also benefit from it.
I expected as much, primarily due to all the work involved. My only concern is 0.3.3 is "broken" depending on your definition of the word but I'll put the more permanent solution in the SO post. I don't know if I personally have the time to maintain an alternative until support ends in 2018 tbh but given where I am it wouldn't hurt to push the box this creates and go the few steps further at least.
How feasible would it be to pull 0.3.3 down, make the change in PR #60, and push that up as 0.3.4? That's the quickest resolution compared to all of this and what I would've done if I thought I could push it to