New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.6 updates to address MySQL password expiration #82

Closed
wants to merge 13 commits into
base: revert-56-master
from

Conversation

Projects
None yet
2 participants
@w0rd-driven

w0rd-driven commented Nov 14, 2016

I'm currently using Homestead 2 and https://atlas.hashicorp.com/laravel/boxes/homestead/versions/0.3.3 which recently got hit by the homestead user's password expiring in mysql 5.7 per http://stackoverflow.com/q/40493594/134335.

As I worked through what I thought would be just simply implementing PR's #59 and #60, I realized it required much more work due to ppa:ondrej/php5-5.6 being deprecated. I realize now I may have been hit by composer/composer#5814, causing the --cableconnected1 and pecl install -Z adjustments though it shouldn't hurt anything to have them in.

There are a few changes I could've made that I'm a little unsure about:

I didn't know if this should be as close to 1:1 with master as possible, though I personally err on that side of things.

This also requires a tandem patch to Homestead v2 as php5-fpm changes to php5.6-fpm, /var/run/php5-fpm.sock changes to /var/run/php/php5.6-fpm.sock, and /etc/php5/fpm/php-fpm.conf changes to /etc/php/5.6/fpm/php-fpm.conf.

I followed the notes from #59 as closely as possible. I tested for the expiration and it is no longer a problem. I made sure I could produce at least 2 builds in a row before calling it done but ultimately produced about 4-5 without failure . I tested a few separate Laravel projects and saw no noticeable awkwardness but these are very rudimentary projects with no redis usage nor would I know what to look for if some of the php extensions are somehow broken. The gist of my latest build is https://gist.github.com/w0rd-driven/f1cfb4b9577ffd391462ba7cbf4c0c8e.

Lastly, I made one improvement that could make it back into master. I moved the xdebug cli disable above pulling in laravel envoy and installer as the provisioning could also benefit from it.

w0rd-driven added some commits Nov 9, 2016

@taylorotwell

This comment has been minimized.

Show comment
Hide comment
@taylorotwell

taylorotwell Nov 15, 2016

Member

I don't really have any plans of maintaining a 5.6 branch of Homestead any longer. You are free to fork this and provide one if you want.

Member

taylorotwell commented Nov 15, 2016

I don't really have any plans of maintaining a 5.6 branch of Homestead any longer. You are free to fork this and provide one if you want.

@w0rd-driven

This comment has been minimized.

Show comment
Hide comment
@w0rd-driven

w0rd-driven Nov 15, 2016

I expected as much, primarily due to all the work involved. My only concern is 0.3.3 is "broken" depending on your definition of the word but I'll put the more permanent solution in the SO post. I don't know if I personally have the time to maintain an alternative until support ends in 2018 tbh but given where I am it wouldn't hurt to push the box this creates and go the few steps further at least.

How feasible would it be to pull 0.3.3 down, make the change in PR #60, and push that up as 0.3.4? That's the quickest resolution compared to all of this and what I would've done if I thought I could push it to laravel/homestead instead of whatever my fork would be.

w0rd-driven commented Nov 15, 2016

I expected as much, primarily due to all the work involved. My only concern is 0.3.3 is "broken" depending on your definition of the word but I'll put the more permanent solution in the SO post. I don't know if I personally have the time to maintain an alternative until support ends in 2018 tbh but given where I am it wouldn't hurt to push the box this creates and go the few steps further at least.

How feasible would it be to pull 0.3.3 down, make the change in PR #60, and push that up as 0.3.4? That's the quickest resolution compared to all of this and what I would've done if I thought I could push it to laravel/homestead instead of whatever my fork would be.

@w0rd-driven w0rd-driven deleted the w0rd-driven:feature/56-updates branch Nov 15, 2016

@w0rd-driven w0rd-driven referenced this pull request Dec 6, 2016

Closed

Expired password #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment