Check nginx.conf for errors before restarting nginx #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adamwathan
suggested changes
Feb 20, 2017
Contributor
adamwathan
left a comment
adamwathan
left a comment
There was a problem hiding this comment.
Couple tweaks but happy to merge after that. Thanks!
| private function lint() | ||
| { | ||
| $this->cli->quietly( | ||
| 'sudo nginx -c '.static::NGINX_CONF.' -t', |
Contributor
There was a problem hiding this comment.
What's this use (&$error) here for? Doesn't look like that variable exists or is used.
cli/Valet/Nginx.php
Outdated
| $this->cli->quietly( | ||
| 'sudo nginx -c '.static::NGINX_CONF.' -t', | ||
| function() use (&$error) { | ||
| info('Nginx cannot start, please check your nginx.conf.'); |
Contributor
There was a problem hiding this comment.
Instead of calling info and dying here, throw a DomainException like we do elsewhere:
https://github.com/laravel/valet/blob/master/cli/Valet/Brew.php#L103
antonioribeiro
force-pushed
the
lintNginxConf
branch
from
3cbff19 to
2ed85e3
Compare
Contributor
Author
|
Done. |
adamwathan
approved these changes
Mar 11, 2017
drbyte
added a commit
to drbyte/valet
that referenced
this pull request
Nov 30, 2019
While since laravel#268 valet has been checking nginx configs for errors when starting/restarting, the captured errors are never displayed if there is a failure because it's being run using `quietly()`. This PR causes the errors to pass through to the console so we can more readily understand why nginx may not be starting or not serving properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before restarting nginx it will execute:
which, on success, must return
And on fail vallet will tell