New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contao] Support the app_dev.php front controller #663

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@leofeyer
Contributor

leofeyer commented Nov 5, 2018

This PR adds support for the app_dev.php front controller:

  • http://folder.test/contao/login -> prod mode
  • http://folder.test/app_dev.php/contao/login -> dev mode with profiler
@mattstauffer

This comment has been minimized.

Contributor

mattstauffer commented Nov 5, 2018

@leofeyer I'm not a Contao dev; could you get some other Contao/Valet users to weigh in on this so I don't commit it when I shouldn't? Thanks!

@leofeyer

This comment has been minimized.

Contributor

leofeyer commented Nov 5, 2018

Sure. Maybe @Toflar can confirm the changes or even make some additions so the driver also supports the Contao manager.

@Toflar

This comment has been minimized.

Toflar commented Nov 6, 2018

I can approve these changes. I'll add support for the mentioned stuff on occasion in a separate PR.

@mattstauffer so you can be sure you can commit: @leofeyer is the Contao project lead and I'm one of the core team developers. And Contao is based on the Symfony full stack framework so it should be fairly similar. Up to you to decide whether that's enough weight though 😄

@leofeyer

This comment has been minimized.

Contributor

leofeyer commented Nov 6, 2018

The logic in the SymfonyValetDriver is different though: they always use app_dev.php if it is present and otherwise app.php (or index.php in Symfony 4).

My changes implement what they initially recommended for Symfony 3 and what we are still using in Contao: https://symfony.com/doc/3.4/setup/web_server_configuration.html#nginx

@mattstauffer

This comment has been minimized.

Contributor

mattstauffer commented Nov 7, 2018

Sounds great; thanks guys! :) I usually just ask for a second person to test it out, less out of a lack of trust of the OP and more just to get multiple folks weighing in and testing out any new code. :) But having the project lead and a core team dev contriubting is definitely great! Thanks! :)

@mattstauffer mattstauffer merged commit 312714d into laravel:master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment