Skip to content

Conversation

@xyNNN
Copy link
Contributor

@xyNNN xyNNN commented Jun 9, 2016

This pull request adds support for Symfony versions which are lower than 3.0, by the way.... awesome work for valet - it work's like a charm :)

@taylorotwell
Copy link
Member

That's slightly generic of a check. Does Symfony 2.x have a more specific file we could look at?

@xyNNN
Copy link
Contributor Author

xyNNN commented Jun 19, 2016

I think the app/AppKernel.php is a very specific file for a Symfony application. So we could improve the condition, what do you think @taylorotwell ?

@taylorotwell
Copy link
Member

taylorotwell commented Jun 19, 2016 via email

@xyNNN
Copy link
Contributor Author

xyNNN commented Jun 19, 2016

I've updated the condition. I think now this driver should support each Symfony 2.x/3.x application ;)

@taylorotwell taylorotwell merged commit 68ff17a into laravel:master Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants