Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications #362

Open
driesvints opened this issue Mar 25, 2018 · 6 comments
Open

Notifications #362

driesvints opened this issue Mar 25, 2018 · 6 comments
Labels

Comments

@driesvints
Copy link
Member

@driesvints driesvints commented Mar 25, 2018

There's already a wip for this at #290. We can make use of the DB implementation to save notifications. Couple this to events and start with the reply notifications.

@driesvints driesvints added the feature label Mar 25, 2018
@taftse

This comment has been minimized.

Copy link
Contributor

@taftse taftse commented Aug 8, 2019

@driesvints Did anything ever happen with this and did you ever get a chance to review the pull requests ?

@driesvints

This comment has been minimized.

Copy link
Member Author

@driesvints driesvints commented Aug 8, 2019

@taftse no sorry. I just don't have the time atm to spend much work on laravel.io or reviewing the prs.

@ryangjchandler

This comment has been minimized.

Copy link
Contributor

@ryangjchandler ryangjchandler commented Mar 10, 2020

@joedixon has implemented this, correct?

@driesvints

This comment has been minimized.

Copy link
Member Author

@driesvints driesvints commented Mar 11, 2020

Not entirely. That was just the first phase. Second phase is realtime notifications with websockets.

@ryangjchandler

This comment has been minimized.

Copy link
Contributor

@ryangjchandler ryangjchandler commented Mar 11, 2020

Not entirely. That was just the first phase. Second phase is realtime notifications with websockets.

Ah I see. Any reason why you're choosing to go with websockets over polling with Livewire?

@driesvints

This comment has been minimized.

Copy link
Member Author

@driesvints driesvints commented Mar 11, 2020

We haven't exactly decided that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.